Attention is currently required from: Hung-Te Lin, Yidi Lin, Yu-Ping Wu, cong yang.
Rui Zhou has posted comments on this change by Rui Zhou. ( https://review.coreboot.org/c/coreboot/+/83287?usp=email )
Change subject: mb/google/geralt: support TAS2563 audio amp
......................................................................
Patch Set 8:
(2 comments)
File src/mainboard/google/geralt/chromeos.c:
https://review.coreboot.org/c/coreboot/+/83287/comment/e366ad65_b3fd35f8?usp... :
PS7, Line 64: fw_config_probe
Align
sorry,I use vim and vscode to view it locally and it is normal, but after submitting it... hum, it seems that I can only use gedit to align it.
File src/mainboard/google/geralt/mainboard.c:
https://review.coreboot.org/c/coreboot/+/83287/comment/e78e06d9_c198f134?usp... :
PS7, Line 39: fw_config_probe
Align
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/83287?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ie9f0cbc30dd950b85581fc1924fa351efe1e0aab
Gerrit-Change-Number: 83287
Gerrit-PatchSet: 8
Gerrit-Owner: Rui Zhou
zhourui@huaqin.corp-partner.google.com
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Yidi Lin
yidilin@google.com
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: cong yang
yangcong5@huaqin.corp-partner.google.com
Gerrit-Attention: Hung-Te Lin
hungte@chromium.org
Gerrit-Attention: Yu-Ping Wu
yupingso@google.com
Gerrit-Attention: Yidi Lin
yidilin@google.com
Gerrit-Attention: cong yang
yangcong5@huaqin.corp-partner.google.com
Gerrit-Comment-Date: Mon, 01 Jul 2024 10:57:10 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Yu-Ping Wu
yupingso@google.com