Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39928 )
Change subject: superio/fintek: Improve code formatting
......................................................................
Patch Set 2: Code-Review+1
(1 comment)
https://review.coreboot.org/c/coreboot/+/39928/2/src/superio/fintek/f81866d/...
File src/superio/fintek/f81866d/f81866d_hwm.c:
https://review.coreboot.org/c/coreboot/+/39928/2/src/superio/fintek/f81866d/...
PS2, Line 35: 0xBA
How about using tabs here, and aligning all hex values to these?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/39928
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I5ae2a2da1994fcc587540586d7404ebf18eb2ca0
Gerrit-Change-Number: 39928
Gerrit-PatchSet: 2
Gerrit-Owner: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Mon, 30 Mar 2020 18:23:01 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment