Angel Pons has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/63515 )
Change subject: nb/intel/sandybridge: Restore `mainboard_early_init()` call ......................................................................
nb/intel/sandybridge: Restore `mainboard_early_init()` call
Commit 7a874330919a4df9cc5b66058b4340465b7ea041 (mb/google,samsung: Drop init_bootmode_straps()) got rid of the `mainboard_early_init()` function call and weak definition in Sandy Bridge code. However, this function is still used by several Sandy Bridge mainboards, so bring back the dropped call and weak definition.
The aforementioned commit did not cause any build-time errors because it did not remove the `mainboard_early_init()` function declaration.
Change-Id: I82768e9a187696d42b61be44d4aa048acc19d551 Signed-off-by: Angel Pons th3fanbus@gmail.com --- M src/northbridge/intel/sandybridge/romstage.c 1 file changed, 6 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/15/63515/1
diff --git a/src/northbridge/intel/sandybridge/romstage.c b/src/northbridge/intel/sandybridge/romstage.c index 1b6e744..56dc677 100644 --- a/src/northbridge/intel/sandybridge/romstage.c +++ b/src/northbridge/intel/sandybridge/romstage.c @@ -16,6 +16,10 @@ #include <southbridge/intel/common/pmclib.h> #include <elog.h>
+__weak void mainboard_early_init(int s3resume) +{ +} + __weak void mainboard_late_rcba_config(void) { } @@ -67,6 +71,8 @@
post_code(0x38);
+ mainboard_early_init(s3resume); + post_code(0x39);
if (CONFIG(INTEL_TXT)) {