Attention is currently required from: Hung-Te Lin, Jarried Lin, Paul Menzel, Yidi Lin.
Yu-Ping Wu has posted comments on this change by Jarried Lin. ( https://review.coreboot.org/c/coreboot/+/85126?usp=email )
Change subject: soc/mediatek/mt8196: Add PMIF and PMIC driver support ......................................................................
Patch Set 12:
(7 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/85126/comment/677edb09_2c59b46a?usp... : PS12, Line 11: fix low : probability boot failure issue Which part of this patch fix the issue? I thought this patch simply adds PMIF feature support instead of fixing issues.
File src/soc/mediatek/mt8196/include/soc/pmif.h:
https://review.coreboot.org/c/coreboot/+/85126/comment/e012cf3a_78150702?usp... : PS12, Line 142: + Space around `+`
https://review.coreboot.org/c/coreboot/+/85126/comment/6c79e218_756c690b?usp... : PS12, Line 142: Just one tab.
https://review.coreboot.org/c/coreboot/+/85126/comment/21f3027c_d377896a?usp... : PS12, Line 142: #define SPMI_SCL_M_PD_ADDR (IOCFG_LM2_BASE+0x80) : #define SPMI_SDA_M_PD_ADDR (IOCFG_LM2_BASE+0x80) : #define SPMI_SCL_P_PD_ADDR (IOCFG_LM2_BASE+0x80) : #define SPMI_SDA_P_PD_ADDR (IOCFG_LM2_BASE+0x80) Why do we need 4 macros, if their values are all the same?
https://review.coreboot.org/c/coreboot/+/85126/comment/b41eb9d1_f0e4ebf0?usp... : PS12, Line 147: ) remove
File src/soc/mediatek/mt8196/pmif_spmi.c:
https://review.coreboot.org/c/coreboot/+/85126/comment/805d6f32_79a664a1?usp... : PS12, Line 164: IOCFG_LM2_BASE + 0x4 Define macros for `IOCFG_LM2_BASE + 0x4` and `IOCFG_LM2_BASE + 0x8`, respecitvely, just like `SPMI_SCL_M_PD_ADDR`.
https://review.coreboot.org/c/coreboot/+/85126/comment/a96977b3_8ecef491?usp... : PS12, Line 221: ( remove