Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36844 )
Change subject: security/vboot: Remove buffer_size from struct vboot_working_data
......................................................................
Patch Set 2:
(2 comments)
https://review.coreboot.org/c/coreboot/+/36844/1/src/lib/coreboot_table.c
File src/lib/coreboot_table.c:
https://review.coreboot.org/c/coreboot/+/36844/1/src/lib/coreboot_table.c@23...
PS1, Line 235: vbwb->range_size = 0;
eventually want to get to the point where we can put this into add_cbmem_pointers() […]
Sure
https://review.coreboot.org/c/coreboot/+/36844/2/src/security/vboot/common.c
File src/security/vboot/common.c:
https://review.coreboot.org/c/coreboot/+/36844/2/src/security/vboot/common.c...
PS2, Line 80: wd->buffer_offset,
nit: maybe that's just me but I'd indent this line one more tab.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/36844
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ie770e89b4a45e0ec703d5bbb8fb6a298ce915056
Gerrit-Change-Number: 36844
Gerrit-PatchSet: 2
Gerrit-Owner: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Joel Kitching
kitching@google.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Fri, 15 Nov 2019 22:11:20 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Yu-Ping Wu
yupingso@google.com
Comment-In-Reply-To: Aaron Durbin
adurbin@chromium.org
Comment-In-Reply-To: Julius Werner
jwerner@chromium.org
Comment-In-Reply-To: Joel Kitching
kitching@google.com
Gerrit-MessageType: comment