Rizwan Qureshi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32051 )
Change subject: mb/google/hatch: Deassert EN_PP3300_WWAN during sleep ......................................................................
Patch Set 2:
(5 comments)
https://review.coreboot.org/#/c/32051/2/src/mainboard/google/hatch/variants/... File src/mainboard/google/hatch/variants/baseboard/gpio.c:
https://review.coreboot.org/#/c/32051/2/src/mainboard/google/hatch/variants/... PS2, Line 412: default_sleep_gpio_table
Do we need an empty table here? Probably okay to just pass back num as 0?
not necessary, but created as place holder anyway for future use. And the code in variant_sleep_gpio_table reads better with this defined.
https://review.coreboot.org/#/c/32051/2/src/mainboard/google/hatch/variants/... PS2, Line 417: EN_PP3300_DX_LTE_SOC
EN_PP3300_WWAN
Done
https://review.coreboot.org/#/c/32051/2/src/mainboard/google/hatch/variants/... PS2, Line 420:
remove tab ?
Done
https://review.coreboot.org/#/c/32051/2/src/mainboard/google/hatch/variants/... PS2, Line 423: variant_sleep_gpio_table
__weak
Done
https://review.coreboot.org/#/c/32051/2/src/mainboard/google/hatch/variants/... File src/mainboard/google/hatch/variants/baseboard/include/baseboard/variants.h:
https://review.coreboot.org/#/c/32051/2/src/mainboard/google/hatch/variants/... PS2, Line 38: variant_sleep_gpio_table
Put this with the other variant_*_gpio_table above?
Done