Felix Held has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/64011 )
Change subject: soc/amd/common/block/psp/psp_gen2: move CORE_2_PSP_MSG_38 defines ......................................................................
soc/amd/common/block/psp/psp_gen2: move CORE_2_PSP_MSG_38 defines
CORE_2_PSP_MSG_38_OFFSET and CORE_2_PSP_MSG_38_FUSE_SPL are only used in psp_gen2.c, so move them into this file.
Signed-off-by: Felix Held felix-coreboot@felixheld.de Change-Id: I67cc2ff63d1c0322b514521975f3ce0f9b1cf5b1 --- M src/soc/amd/common/block/psp/psp_def.h M src/soc/amd/common/block/psp/psp_gen2.c 2 files changed, 3 insertions(+), 3 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/11/64011/1
diff --git a/src/soc/amd/common/block/psp/psp_def.h b/src/soc/amd/common/block/psp/psp_def.h index f171efe..4d860ff 100644 --- a/src/soc/amd/common/block/psp/psp_def.h +++ b/src/soc/amd/common/block/psp/psp_def.h @@ -26,9 +26,6 @@ #define MBOX_BIOS_CMD_SMU_FW 0x19 #define MBOX_BIOS_CMD_SMU_FW2 0x1a
-#define CORE_2_PSP_MSG_38_OFFSET 0x10998 -#define CORE_2_PSP_MSG_38_FUSE_SPL BIT(12) - /* command/response format, BIOS builds this in memory * mbox_buffer_header: generic header * mbox_buffer: command-specific buffer format diff --git a/src/soc/amd/common/block/psp/psp_gen2.c b/src/soc/amd/common/block/psp/psp_gen2.c index 12f5fec..80650cb 100644 --- a/src/soc/amd/common/block/psp/psp_gen2.c +++ b/src/soc/amd/common/block/psp/psp_gen2.c @@ -13,6 +13,9 @@ #define PSP_MAILBOX_COMMAND_OFFSET 0x10570 /* 4 bytes */ #define PSP_MAILBOX_BUFFER_OFFSET 0x10574 /* 8 bytes */
+#define CORE_2_PSP_MSG_38_OFFSET 0x10998 /* 4 byte */ +#define CORE_2_PSP_MSG_38_FUSE_SPL BIT(12) + union pspv2_mbox_command { u32 val; struct pspv2_mbox_cmd_fields {