Attention is currently required from: Julius Werner.
Maximilian Brune has posted comments on this change by Maximilian Brune. ( https://review.coreboot.org/c/coreboot/+/83085?usp=email )
Change subject: commonlib/device_tree.c: Fix results length check ......................................................................
Patch Set 4:
(1 comment)
File src/lib/device_tree.c:
https://review.coreboot.org/c/coreboot/+/83085/comment/858c3a2a_5961f42c?usp... : PS1, Line 363: if (count_results > results_len) {
Yes it is not correct. I meant to change that (forgot to set the patch to WIP). […]
The current implementation should work. But I am thinking of just ditching the warning. It keeps us in the loop even if we reached the maximum number of nodes already. I would also assume that the caller knows what it is searching for and therefore knows a sane maximum value?