Attention is currently required from: Sean Rhodes, Paul Menzel, Tim Wawrzynczak, Ben McMillen, Elyes Haouas.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/65785 )
Change subject: mb/starlabs/starbook: Add Alder Lake StarBook Mk VI variant
......................................................................
Patch Set 27: Code-Review+1
(1 comment)
File src/mainboard/starlabs/starbook/variants/adl/hda_verb.c:
https://review.coreboot.org/c/coreboot/+/65785/comment/0872fd99_95da5a23
PS26, Line 71: u32
`uint32_t` preferred?
It's just that Elyes wants you to include the header. No one else seems to do it because it's chain-included via azalia_device.h
--
To view, visit
https://review.coreboot.org/c/coreboot/+/65785
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Idc0c265a88b19cf9e89cc8ab3e8db9abd8cf8409
Gerrit-Change-Number: 65785
Gerrit-PatchSet: 27
Gerrit-Owner: Ben McMillen
ben@starlabs.systems
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Paul Menzel
paulepanter@mailbox.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Elyes Haouas
ehaouas@noos.fr
Gerrit-CC: Sean Rhodes
sean@starlabs.systems
Gerrit-CC: Tim Wawrzynczak
inforichland@gmail.com
Gerrit-Attention: Sean Rhodes
sean@starlabs.systems
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Tim Wawrzynczak
inforichland@gmail.com
Gerrit-Attention: Ben McMillen
ben@starlabs.systems
Gerrit-Attention: Elyes Haouas
ehaouas@noos.fr
Gerrit-Comment-Date: Sun, 13 Nov 2022 21:34:59 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Sean Rhodes
sean@starlabs.systems
Comment-In-Reply-To: Elyes Haouas
ehaouas@noos.fr
Gerrit-MessageType: comment