Attention is currently required from: Paul Menzel, Karthik Ramasubramanian.
Rob Barnes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60139 )
Change subject: mb/google/guybrush: Enable PSP_S0I3_RESUME_VERSTAGE
......................................................................
Patch Set 2:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/60139/comment/3eaf2c7e_4102e057
PS1, Line 11: in verstage during s0i3 resume
Please add a dot/period at the end of sentences.
Done
https://review.coreboot.org/c/coreboot/+/60139/comment/c3396747_404463da
PS1, Line 12:
Why does the TPM need to be reinitialized?
Amended commit message
Why can't the OS do it?
The TPM must be initialized by coreboot to meet security requirements.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/60139
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I9d64fe92ffc67a421be6d5e013e636332ce86dd5
Gerrit-Change-Number: 60139
Gerrit-PatchSet: 2
Gerrit-Owner: Rob Barnes
robbarnes@google.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Comment-Date: Thu, 16 Dec 2021 14:16:17 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel
paulepanter@mailbox.org
Gerrit-MessageType: comment