Attention is currently required from: Jason Glenesk, Raul Rangel, Martin Roth, Marshall Dawson, Paul Menzel, Fred Reitberger, Rob Barnes, Karthik Ramasubramanian. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/61259 )
Change subject: soc/amd/cezanne: Turn off gpp clock request for disabled devices ......................................................................
Patch Set 36:
(4 comments)
File src/soc/amd/cezanne/fch.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-144382): https://review.coreboot.org/c/coreboot/+/61259/comment/1146a31d_4eb27be6 PS36, Line 184: printk(BIOS_ERR, "Failed to convert DXIO clk req value %d to GPP clk req index \ line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-144382): https://review.coreboot.org/c/coreboot/+/61259/comment/d885e850_c9c361ec PS36, Line 184: printk(BIOS_ERR, "Failed to convert DXIO clk req value %d to GPP clk req index \ Avoid line continuations in quoted strings
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-144382): https://review.coreboot.org/c/coreboot/+/61259/comment/bb076e09_00b74b5b PS36, Line 185: for PCIe device %d.%d, DXIO descriptor %d, clk req settings may be incorrect\n", line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-144382): https://review.coreboot.org/c/coreboot/+/61259/comment/b500a5b5_4ee7a620 PS36, Line 186: dxio_clk_req, dxio_desc->device_number, dxio_desc->function_number, i); line over 96 characters