Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43994 )
Change subject: soc/intel/cannonlake: Fix DMAR when no iGPU is present
......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/43994/2/src/soc/intel/cannonlake/ac...
File src/soc/intel/cannonlake/acpi.c:
https://review.coreboot.org/c/coreboot/+/43994/2/src/soc/intel/cannonlake/ac...
PS2, Line 297: /* Add RMRR entry */
Wait... Apparently VT-d spec says that RMRRs need to be added after all DRHDs have been added. […]
You are right. Checked Document D51397-011.
Then the following platforms are wrong: APL, SDY, BDW, SKL
--
To view, visit
https://review.coreboot.org/c/coreboot/+/43994
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iafe86e6938a120b707aaae935cb8168f790bb22f
Gerrit-Change-Number: 43994
Gerrit-PatchSet: 2
Gerrit-Owner: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Christian Walter
christian.walter@9elements.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Philipp Deppenwiese
philipp.deppenwiese@9elements.com
Gerrit-Reviewer: Philipp Deppenwiese
zaolin.daisuki@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Patrick Rudolph
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Wed, 29 Jul 2020 05:17:14 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment