Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42226 )
Change subject: mb/google/zork: Enable psp_verstage
......................................................................
Patch Set 5:
(2 comments)
https://review.coreboot.org/c/coreboot/+/42226/5/src/mainboard/google/zork/K...
File src/mainboard/google/zork/Kconfig:
https://review.coreboot.org/c/coreboot/+/42226/5/src/mainboard/google/zork/K...
PS5, Line 154: default y if VBOOT
Do we want to make this default or select it in our chromium configs?
https://review.coreboot.org/c/coreboot/+/42226/5/src/mainboard/google/zork/K...
PS5, Line 162: select VBOOT_SEPARATE_VERSTAGE
shouldn't we be selecting this for VBOOT_STARTS_BEFORE_BOOTBLOCK as well?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/42226
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If6a12c2074d7c84c0cb766393c66f5eff29a58d5
Gerrit-Change-Number: 42226
Gerrit-PatchSet: 5
Gerrit-Owner: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Eric Peers
epeers@google.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Thu, 25 Jun 2020 05:15:43 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment