Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40580 )
Change subject: soc/intel/cometlake: Add ucode from repo ......................................................................
Patch Set 6:
(3 comments)
https://review.coreboot.org/c/coreboot/+/40580/6//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/40580/6//COMMIT_MSG@12 PS6, Line 12: - 06-a6-00 (CPUID: 0xa0660) Both encodings are the cpuid. A little less ambiguous: the latter is usually referred to as `cpuid signature`.
https://review.coreboot.org/c/coreboot/+/40580/6/src/soc/intel/cannonlake/Ma... File src/soc/intel/cannonlake/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/40580/6/src/soc/intel/cannonlake/Ma... PS6, Line 110: else ifeq ($(CONFIG_SOC_INTEL_COMETLAKE),y) also check that CONFIG_SOC_INTEL_CANNONLAKE_PCH_H != y
https://review.coreboot.org/c/coreboot/+/40580/6/src/soc/intel/cannonlake/Ma... PS6, Line 112: cpu_microcode_bins += 3rdparty/intel-microcode/intel-ucode/06-a6-00 Please leave a comment that 06-a6-01 is missing in the repository.