Attention is currently required from: Felix Held, Felix Singer, Nicholas Sudsgaard, Paul Menzel.
Elyes Haouas has posted comments on this change by Nicholas Sudsgaard. ( https://review.coreboot.org/c/coreboot/+/80332?usp=email )
Change subject: device/azalia: Separate codec checking and initialization
......................................................................
Patch Set 9:
(1 comment)
File src/device/azalia_device.c:
https://review.coreboot.org/c/coreboot/+/80332/comment/2ca06a33_1c590dbf?usp... :
PS5, Line 249: u32
yes, that's a separate logical change, so please do that in a follow-up
Acknowledged
--
To view, visit
https://review.coreboot.org/c/coreboot/+/80332?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I92b6d184abccdbe0e1bfce98a2c959a97a618a29
Gerrit-Change-Number: 80332
Gerrit-PatchSet: 9
Gerrit-Owner: Nicholas Sudsgaard
devel+coreboot@nsudsgaard.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Felix Singer
service+coreboot-gerrit@felixsinger.de
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Elyes Haouas
ehaouas@noos.fr
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Felix Singer
service+coreboot-gerrit@felixsinger.de
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Nicholas Sudsgaard
devel+coreboot@nsudsgaard.com
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Sun, 23 Jun 2024 06:57:37 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Felix Singer
service+coreboot-gerrit@felixsinger.de
Comment-In-Reply-To: Nicholas Sudsgaard
devel+coreboot@nsudsgaard.com
Comment-In-Reply-To: Felix Held
felix-coreboot@felixheld.de
Comment-In-Reply-To: Elyes Haouas
ehaouas@noos.fr