HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40368 )
Change subject: nb/i945: Reorder sdram_setup_processor_side()
......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/40368/3//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/40368/3//COMMIT_MSG@7
PS3, Line 7: Reorder
why? You might want to use a variable instead of calling i945_silicon_revision() twice?
I'm not using a variable.
I just call i945_silicon_revision() one time and write 2 MCHBAR registers.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/40368
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ida21eb648f92ff0545dc0ce4da3aa9135b1260a9
Gerrit-Change-Number: 40368
Gerrit-PatchSet: 3
Gerrit-Owner: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Arthur Heymans
arthur@aheymans.xyz
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Thu, 16 Apr 2020 12:41:07 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Arthur Heymans
arthur@aheymans.xyz
Gerrit-MessageType: comment