8 Jul
2024
8 Jul
'24
6:29 a.m.
Attention is currently required from: Felix Held.
Maximilian Brune has posted comments on this change by Maximilian Brune. ( https://review.coreboot.org/c/coreboot/+/83375?usp=email )
Change subject: Revert "Makefile.mk: Remove bc dependency" ......................................................................
Patch Set 2:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/83375/comment/d63d0390_cc64ba7b?usp... : PS1, Line 13: Change-Id: Ibf9041b0095ac486d4ee7e8925be8cebb13d2c8f
Missing Signed-off-by line.
Interesting gerrit doesn't seem to add it by default if I use the gerrit UI to revert a patch.
--
To view, visit https://review.coreboot.org/c/coreboot/+/83375?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ibf9041b0095ac486d4ee7e8925be8cebb13d2c8f
Gerrit-Change-Number: 83375
Gerrit-PatchSet: 2
Gerrit-Owner: Maximilian Brune maximilian.brune@9elements.com
Gerrit-Reviewer: Felix Held felix-coreboot@felixheld.de
Gerrit-Reviewer: Felix Singer service+coreboot-gerrit@felixsinger.de
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Attention: Felix Held felix-coreboot@felixheld.de
Gerrit-Comment-Date: Mon, 08 Jul 2024 13:29:58 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Felix Singer service+coreboot-gerrit@felixsinger.de