Attention is currently required from: Maciej Pijanowski, Jakub Czapiga, Karol Zmyslowski, Stefan Reinauer, Michal Zygowski.
Michał Żygowski has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/73934 )
Change subject: util/inteltool: Add support for Jasper Lake ......................................................................
Patch Set 19:
(8 comments)
File util/inteltool/gpio_names/jasperlake.h:
https://review.coreboot.org/c/coreboot/+/73934/comment/27287057_eb81584c PS19, Line 543: "GPP_DSW00", "PMC_BATLOW_N", : "GPP_DSW01", "PMC_ACPRESENT", : "GPP_DSW02", "LAN_WAKE_N", : "GPP_DSW03", "PMC_PWRBTN_N", : "GPP_DSW04", "PMC_SLP_S3_N", : "GPP_DSW05", "PMC_SLP_S4_N", : "GPP_DSW06", "PMC_SLP_A_N", : "GPP_DSW07", "n/a", : "GPP_DSW08", "PMC_SUSCLK", : "GPP_DSW09", "PMC_SLP_WLAN_N", : "GPP_DSW10 GPD, not GPP_DSW to keep consistency with other microarchitectures
File util/inteltool/gpio_names/jasperlake.h:
https://review.coreboot.org/c/coreboot/+/73934/comment/d5f6640f_b1924e00 PS17, Line 15: "ESPI_RESET,_N",
Done
Ack
https://review.coreboot.org/c/coreboot/+/73934/comment/210239f1_187ff932 PS17, Line 18: "SMB_ALERT_,N",
Done
Ack
https://review.coreboot.org/c/coreboot/+/73934/comment/557e524a_43cdf2cd PS17, Line 148: "GPP_L_BKLTEN", "GPP_L_BKLTEN", : "GPP_L_BKLTCTL", "GPP_L_BKLTCTL", : "GPP_LVDDEN", "GPP_LVDDEN", : "GPP_SYS_PWROK", "GPP_SYS_PWROK", : "GPP_SYS_RESETB", "GPP_SYS_RESETB", : "GPP_MLK_RSTB", "GPP_MLK_RSTB",
Done
Ack
https://review.coreboot.org/c/coreboot/+/73934/comment/5fe4aed5_19158be3 PS17, Line 157: GPP_HVCMOS
Done
Ack
https://review.coreboot.org/c/coreboot/+/73934/comment/31c1e67a_36c6559c PS17, Line 503: const char *const jasperlake_pch_group_vgpio_padding_names [] ={
Done
Ack
https://review.coreboot.org/c/coreboot/+/73934/comment/f33f0d7e_c6f84b50 PS17, Line 554: "GPD_INPUT3VSEL", "GPD_INPUT3VSEL", : "GPD_SLP_SUSB", "GPD_SLP_SUSB", : "GPD_WAKEB", "GPD_WAKEB", : "GPD_DRAM_RESETB", "GPD_DRAM_RESETB",
Done
Ack
File util/inteltool/gpio_names/jasperlake.h:
https://review.coreboot.org/c/coreboot/+/73934/comment/a8b09fa4_26c6c2ad PS4, Line 496: // Deep Sleep Well group : const char *const jasperlake_pch_group_dsw_names[] = { : "GPP_DSW00", "PMC_BATLOW_N", : "GPP_DSW01", "PMC_ACPRESENT", : "GPP_DSW02", "LAN_WAKE_N", : "GPP_DSW03", "PMC_PWRBTN_N", : "GPP_DSW04", "PMC_SLP_S3_N", : "GPP_DSW05", "PMC_SLP_S4_N", : "GPP_DSW06", "PMC_SLP_A_N", : "GPP_DSW07", "n/a", : "GPP_DSW08", "PMC_SUSCLK", : "GPP_DSW09", "PMC_SLP_WLAN_N", : "GPP_DSW10", "PMC_SLP_S5_N", : }; :
This is actually the GPD group (abbreviation for GPP_DSW). […]
Ack