Mimoja has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34537 )
Change subject: src/device/oprom: Fix bootsplash display code for optionroms ......................................................................
Patch Set 23:
(7 comments)
https://review.coreboot.org/c/coreboot/+/34537/22/src/device/Makefile.inc File src/device/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/34537/22/src/device/Makefile.inc@51 PS22, Line 51:
Unrelated whitespace change.
Done
https://review.coreboot.org/c/coreboot/+/34537/22/src/device/oprom/realmode/... File src/device/oprom/realmode/x86.c:
https://review.coreboot.org/c/coreboot/+/34537/22/src/device/oprom/realmode/... PS22, Line 224: vbe_mode_info_t mode_info;
static, if possible
Done
https://review.coreboot.org/c/coreboot/+/34537/22/src/device/oprom/realmode/... PS22, Line 235: return NULL;
Change to: […]
Done
https://review.coreboot.org/c/coreboot/+/34537/22/src/device/oprom/yabel/vbe... File src/device/oprom/yabel/vbe.c:
https://review.coreboot.org/c/coreboot/+/34537/22/src/device/oprom/yabel/vbe... PS22, Line 716: vbe_mode_info_t mode_info;
static, if possible
Done
https://review.coreboot.org/c/coreboot/+/34537/22/src/device/oprom/yabel/vbe... PS22, Line 722: }
Remove 717-722, duplicates of 166-171. Try build with oprom in "secure mode" to combile yabel code.
Done
https://review.coreboot.org/c/coreboot/+/34537/22/src/device/oprom/yabel/vbe... PS22, Line 726: if (!mode_info_valid)
Like the other file.
Done
https://review.coreboot.org/c/coreboot/+/34537/22/src/include/vbe.h File src/include/vbe.h:
https://review.coreboot.org/c/coreboot/+/34537/22/src/include/vbe.h@105 PS22, Line 105: const vbe_mode_info_t *vbe_mode_info(void);
Document use, noting it returns NULL in case there is no linear framebuffer.
Done