Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31358 )
Change subject: mb/google/hatch: Use MEM_CH_SEL to indicate single_channel sku ......................................................................
Patch Set 15:
(3 comments)
Don't you also need to update this: https://review.coreboot.org/cgit/coreboot.git/tree/src/mainboard/google/hatc...
https://review.coreboot.org/#/c/31358/15/src/mainboard/google/hatch/variants... File src/mainboard/google/hatch/variants/baseboard/gpio.c:
https://review.coreboot.org/#/c/31358/15/src/mainboard/google/hatch/variants... PS15, Line 284: DN_20K Why is the pull-down required?
https://review.coreboot.org/#/c/31358/15/src/mainboard/google/hatch/variants... PS15, Line 432: DN_20K same here
https://review.coreboot.org/#/c/31358/15/src/mainboard/google/hatch/variants... File src/mainboard/google/hatch/variants/baseboard/memory.c:
https://review.coreboot.org/#/c/31358/15/src/mainboard/google/hatch/variants... PS15, Line 22: baseboard_memcfg Do these params apply to both hatch and hatch_whl?