Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48172 )
Change subject: soc/intel/common/block/smm/smihandler: Fix compilation under x86_64
......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/48172/1/src/soc/intel/common/block/...
File src/soc/intel/common/block/smm/smihandler.c:
https://review.coreboot.org/c/coreboot/+/48172/1/src/soc/intel/common/block/...
PS1, Line 295: uint32_t
this explicitly truncates get_reg, which you should probably not change here.
Ack
--
To view, visit
https://review.coreboot.org/c/coreboot/+/48172
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ie44ded11a6a9ddd2a1163d2f57dad6935e1ea167
Gerrit-Change-Number: 48172
Gerrit-PatchSet: 2
Gerrit-Owner: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Comment-Date: Tue, 01 Dec 2020 09:18:57 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Arthur Heymans
arthur@aheymans.xyz
Gerrit-MessageType: comment