Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/70057 )
Change subject: Makefile: Add printall as a NOCOMPILE target ......................................................................
Makefile: Add printall as a NOCOMPILE target
Previously, running "make printall" when there was no .config available, the system would give an error that printall wasn't a valid target. This is because it was only in an invalid if clause. This change adds it to the other branch of the if clause so it will print out a notice of what the issue is.
Signed-off-by: Martin Roth gaumless@gmail.com Change-Id: I20670ae875be67ac2edf877c53de4702c4fc7c7d Reviewed-on: https://review.coreboot.org/c/coreboot/+/70057 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Jakub Czapiga jacz@semihalf.com Reviewed-by: Angel Pons th3fanbus@gmail.com --- M Makefile 1 file changed, 22 insertions(+), 1 deletion(-)
Approvals: build bot (Jenkins): Verified Angel Pons: Looks good to me, approved Jakub Czapiga: Looks good to me, approved
diff --git a/Makefile b/Makefile index 58cd85b..e817992 100644 --- a/Makefile +++ b/Makefile @@ -148,13 +148,14 @@ include $(TOPLEVEL)/util/testing/Makefile.inc -include $(TOPLEVEL)/site-local/Makefile.inc include $(TOPLEVEL)/tests/Makefile.inc -real-all: +printall real-all: @echo "Error: Trying to build, but NOCOMPILE is set." >&2 @echo " Please file a bug with the following information:" @echo "- MAKECMDGOALS: $(MAKECMDGOALS)" >&2 @echo "- HAVE_DOTCONFIG: $(HAVE_DOTCONFIG)" >&2 @echo "- HAVE_KCONFIG_MAKEFILE_REAL: $(HAVE_KCONFIG_MAKEFILE_REAL)" >&2 @exit 1 + else
ifneq ($(UNIT_TEST),1)