Attention is currently required from: Alicja Michalska, Angel Pons, Arthur Heymans, Christian Walter, Johnny Lin, Jonathan Zhang, Patrick Rudolph, Tim Chu.
Shuo Liu has posted comments on this change by Shuo Liu. ( https://review.coreboot.org/c/coreboot/+/84304?usp=email )
Change subject: soc/intel/xeon_sp: Use MemoryMapDataHob to add high RAM resources
......................................................................
Patch Set 2:
(4 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/84304/comment/166392ba_f294563c?usp... :
PS1, Line 9: window
Use plural: window*s*
Done
https://review.coreboot.org/c/coreboot/+/84304/comment/8817d2ef_5fc16f1e?usp... :
PS1, Line 10: no
typo: on
Done
https://review.coreboot.org/c/coreboot/+/84304/comment/72715974_3e21d388?usp... :
PS1, Line 13: mechanism for GNR and previous generation SoCs.
Has this change been tested? If so, on which platforms and how? I would recommend testing on previou […]
Sure, updated the tests.
File src/soc/intel/xeon_sp/uncore.c:
https://review.coreboot.org/c/coreboot/+/84304/comment/ca2cda10_1b02ca6c?usp... :
PS1, Line 288: const struct SystemMemoryMapHob *mm = get_system_memory_map();
`code indent should use tabs where possible` […]
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/84304?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ie5fbc5735704d95c7ad50740ff0e35737afdbd80
Gerrit-Change-Number: 84304
Gerrit-PatchSet: 2
Gerrit-Owner: Shuo Liu
shuo.liu@intel.com
Gerrit-Reviewer: Alicja Michalska
ahplka19@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Christian Walter
christian.walter@9elements.com
Gerrit-Reviewer: Johnny Lin
Johnny_Lin@wiwynn.com
Gerrit-Reviewer: Jonathan Zhang
jon.zhixiong.zhang@gmail.com
Gerrit-Reviewer: Lean Sheng Tan
sheng.tan@9elements.com
Gerrit-Reviewer: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Tim Chu
Tim.Chu@quantatw.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Alicja Michalska
ahplka19@gmail.com
Gerrit-Attention: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Attention: Jonathan Zhang
jon.zhixiong.zhang@gmail.com
Gerrit-Attention: Johnny Lin
Johnny_Lin@wiwynn.com
Gerrit-Attention: Christian Walter
christian.walter@9elements.com
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Attention: Tim Chu
Tim.Chu@quantatw.com
Gerrit-Comment-Date: Fri, 20 Sep 2024 01:55:55 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com