Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31255 )
Change subject: cpu/intel/model_1067x: Check for lock bit on IA32_FEATURE_CONTROL
......................................................................
Patch Set 4:
(1 comment)
https://review.coreboot.org/#/c/31255/4/src/cpu/intel/model_1067x/mp_init.c
File src/cpu/intel/model_1067x/mp_init.c:
https://review.coreboot.org/#/c/31255/4/src/cpu/intel/model_1067x/mp_init.c@...
PS4, Line 66: printk(BIOS_DEBUG, "IA32_FEATURE_CONTROL already locked\n");
Is that expected? If not, a lower log level like NOTICE might be useful.
It is expected on reboots at least. It is the same loglevel as cpu/intel/common/common_init.c which does something similar.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/31255
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I7d2df9e1b9d767809da7a61ccd877c6c40f132eb
Gerrit-Change-Number: 31255
Gerrit-PatchSet: 4
Gerrit-Owner: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Bill XIE
persmule@gmail.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Wed, 06 Feb 2019 14:57:05 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-MessageType: comment