Attention is currently required from: Arthur Heymans, Martin L Roth, Subrata Banik.
Jérémy Compostella has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/75905?usp=email )
Change subject: Makefile.inc: Compress DSDT file
......................................................................
Patch Set 4:
(3 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/75905/comment/7c1b8df6_fcb6f307 :
PS4, Line 9: dsdt
`s/dsdt/DSDT ACPI table/`
https://review.coreboot.org/c/coreboot/+/75905/comment/424ef62e_34d395eb :
PS4, Line 11: 128K
I believe you meant 64 KiB.
File Makefile.inc:
https://review.coreboot.org/c/coreboot/+/75905/comment/01e9aed2_4c27242e :
PS4, Line 300: LZMA
We have been using lower case for compression algorithm in most places according to `grep` so I would recommend to stick to lower case.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/75905?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I3f555b1761c7ef4943d8de447ab299684403214b
Gerrit-Change-Number: 75905
Gerrit-PatchSet: 4
Gerrit-Owner: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Jérémy Compostella
jeremy.compostella@intel.com
Gerrit-Reviewer: Martin L Roth
gaumless@gmail.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Attention: Martin L Roth
gaumless@gmail.com
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Comment-Date: Mon, 22 Jan 2024 17:01:19 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment