Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31983 )
Change subject: device/pci_device: Add generic subsystem programming logic ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/#/c/31983/1/src/device/pci_device.c File src/device/pci_device.c:
https://review.coreboot.org/#/c/31983/1/src/device/pci_device.c@746 PS1, Line 746: cap_offset = pci_find_capability(dev, PCI_CAP_ID_SSVID);
It will return 0 if missing, should not happen but must skip the write in that case. […]
offset one i have fixed.
Didn't get this one
It will return 0 if missing, should not happen but must skip the write in that case.
do you mean like below? if (!offset) return;