Attention is currently required from: Paul Menzel, Angel Pons, Arthur Heymans.
Werner Zeh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62699 )
Change subject: lib/spd: Do not print part number if it is not available
......................................................................
Patch Set 4:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/62699/comment/1d825d93_40089cc9
PS4, Line 11:
TBH, I'm more concerned about the log level. […]
I guess it can be helpful here and there. But for these cases a DEBUG would be fine as well, I guess. On the other hand, INFO is just one level below DEBUG. So I personally do not have a strong opinion here.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/62699
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If7224c6e114731b1c03915a2bde80f57369d0cee
Gerrit-Change-Number: 62699
Gerrit-PatchSet: 4
Gerrit-Owner: Werner Zeh
werner.zeh@siemens.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Nick Vaccaro
nvaccaro@google.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Comment-Date: Mon, 14 Mar 2022 09:55:17 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Subrata Banik
subratabanik@google.com
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Comment-In-Reply-To: Werner Zeh
werner.zeh@siemens.com
Gerrit-MessageType: comment