Attention is currently required from: Michał Żygowski. Hello build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/62210
to look at the new patch set (#2).
Change subject: mb/dell/optiplex_9010/sch5545_ec.c: Fix HWM initialization bugs ......................................................................
mb/dell/optiplex_9010/sch5545_ec.c: Fix HWM initialization bugs
Fix the HWM sequence matching to the chassis. HWM sequence for SFF was incorrectly passed to MT chassis HWM initialization.
Vendor code also applies a fix-up for MT/DT chassis. This fixup was missing one register read compared to the vendor code. Add the missing read and guard the fixup depening on the returned value to match the vendor code behavior. Not doing so resulted in increased fan speeds on Dell Precision T1650 compared to Dell's firmware.
TEST=Boot Dell Precision T1650 and hear the fans are as silent as on Dell's firmware
Signed-off-by: Michał Żygowski michal.zygowski@3mdeb.com Change-Id: I5c0e1c00e69d66848a602ad91a3e83375a095f44 --- M src/mainboard/dell/optiplex_9010/sch5545_ec.c 1 file changed, 24 insertions(+), 20 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/10/62210/2