Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35634 )
Change subject: vboot: create board-specific test-only GBB HWID if not set ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/35634/1/src/security/vboot/gen_hwid... File src/security/vboot/gen_hwid.sh:
https://review.coreboot.org/c/coreboot/+/35634/1/src/security/vboot/gen_hwid... PS1, Line 38: crc="$(python -c "import zlib, sys; sys.stdout.write(\
Like said, the vboot does not define how HWID should look like. It only expects a string.
Understood.
Unless you're suggesting to make a "calculate CRC32" general function (not for hwid), otherwise it'll be adding a deprecated feature, or breaking all HWID v3/v4 systems.
Kind of. I was thinking of having a calculate crc32 function in futility. Then you could either: a) Call futility to calculate that and use in Makefile. b) Add an option in gbb_utility to say append CRC32 to HWID. It will end up being used only by coreboot. And, it will require adding some knowledge to vboot/futility what append to HWID means.
Anyways, I was just curious and hence the question. I am okay if you want to just add a script to do this since its use is limited to coreboot.