Yu-Ping Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35555 )
Change subject: mediatek/mt8183: Save DRAM calibration result to shuffle for DVFS switch ......................................................................
Patch Set 7:
(1 comment)
https://review.coreboot.org/c/coreboot/+/35555/7/src/soc/mediatek/mt8183/emi... File src/soc/mediatek/mt8183/emi.c:
https://review.coreboot.org/c/coreboot/+/35555/7/src/soc/mediatek/mt8183/emi... PS7, Line 345: emi_init2(params);
those work flow was implemented under hardware designer's guidance, so the result of switch those bl […]
What I don't understand is that emi_init2() is called between calls of dfs_init_for_calibration().
Either
emi_init2(params); dfs_init_for_calibration(params, SHUFFLE3); dfs_init_for_calibration(params, SHUFFLE2); dfs_init_for_calibration(params, SHUFFLE1);
or
dfs_init_for_calibration(params, SHUFFLE3); emi_init2(params); dfs_init_for_calibration(params, SHUFFLE2); emi_init2(params); dfs_init_for_calibration(params, SHUFFLE1); emi_init2(params);
seems more reasonable to me. Could you kindly check with the hardware designer?