Attention is currently required from: Francois Toguo Fotso, Paul Menzel, Curtis Chen, Patrick Rudolph. Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59951 )
Change subject: soc/intel/common: Do not trigger crashlog on all resets by default ......................................................................
Patch Set 4: Code-Review+1
(5 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/59951/comment/2002f0b0_db2e59c9 PS1, Line 9: This feature should : not be enabled by default.
If this feature is enabled, each PMC reset would trigger crashlog. […]
Done
https://review.coreboot.org/c/coreboot/+/59951/comment/218de70c_ae252d41 PS1, Line 13: apreset
ec command "apreset"
suggestion: ``` ls /var/spool/crash/*.bertdump` should be empty after a warm reset ```
Patchset:
PS2:
Do you mind splitting this into two commits, one for the Kconfig, and the other to enable it for A […]
I see, this seems OK.
File src/soc/intel/common/Kconfig.common:
https://review.coreboot.org/c/coreboot/+/59951/comment/0e991d14_12b39416 PS4, Line 87: CrashLog nit: `Crashlog`
https://review.coreboot.org/c/coreboot/+/59951/comment/d83dc349_7d326b44 PS4, Line 92: Enable PMC reset crashlog record. suggestion: ``` Enables the PMC to collect crashlog records on every reset event. NOTE: This will result in a BERT table being populated containing a PMC crashlog record on every boot. ```