Mike Banon has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33796 )
Change subject: asus/am1i-a: Enable UART according to CONFIG_UART_FOR_CONSOLE ......................................................................
Patch Set 5:
(2 comments)
Thank you very much for your help and beautiful code, I hope it is better now.
https://review.coreboot.org/#/c/33796/4//COMMIT_MSG Commit Message:
https://review.coreboot.org/#/c/33796/4//COMMIT_MSG@7 PS4, Line 7: Fix UART 0 port while preserving UART 1 functionality
I'd update the summary, e.g.: Enable UART according to CONFIG_UART_FOR_CONSOLE […]
Done.
https://review.coreboot.org/#/c/33796/3/src/mainboard/asus/am1i-a/romstage.c File src/mainboard/asus/am1i-a/romstage.c:
https://review.coreboot.org/#/c/33796/3/src/mainboard/asus/am1i-a/romstage.c... PS3, Line 29: CONFIG_TTYS0_BASE
The only valid values are 0 and 1, aren't they? Explicitly check for them: […]
Done.