Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31516 )
Change subject: google/kukui: boot up sspm ......................................................................
Patch Set 1:
(5 comments)
Where will the firmware be available?
https://review.coreboot.org/#/c/31516/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/#/c/31516/1//COMMIT_MSG@9 PS1, Line 9: Load sspm firmware form cbfs and bring up it. bring it up
https://review.coreboot.org/#/c/31516/1//COMMIT_MSG@9 PS1, Line 9: form from
https://review.coreboot.org/#/c/31516/1//COMMIT_MSG@10 PS1, Line 10: Please describe what SSPM is, or where it is documented.
https://review.coreboot.org/#/c/31516/1//COMMIT_MSG@13 PS1, Line 13: Boots correctly on Kukui. How do you verify that SSPM firmware was loaded and works?
https://review.coreboot.org/#/c/31516/1/src/mainboard/google/kukui/Kconfig File src/mainboard/google/kukui/Kconfig:
https://review.coreboot.org/#/c/31516/1/src/mainboard/google/kukui/Kconfig@6... PS1, Line 69: string "SSPM BIN FILE" Please add a help text.