Attention is currently required from: Lance Zhao, Subrata Banik, Rizwan Qureshi, Tim Wawrzynczak, Eric Lai.
Varshit B Pandya has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63315 )
Change subject: drivers/intel/dptf: Add support for Battery participant
......................................................................
Patch Set 2:
(2 comments)
Patchset:
PS1:
Will this duplicate from EC BAT0?
I believe BAT0 of EC0 would be under _SB.PCI0.LPCB.EC0.BAT0 and this would be under _SB.DPTF.BAT1, so would be still conflicting ?
File src/drivers/intel/dptf/dptf.c:
https://review.coreboot.org/c/coreboot/+/63315/comment/11255003_26deefdb
PS1, Line 17: DPTF_GENERIC_PARTICIPANT_TYPE_POWER = 0x11,
nits:put in order
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/63315
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I9104318fd838f30253ab1eeac4e212b3b917f516
Gerrit-Change-Number: 63315
Gerrit-PatchSet: 2
Gerrit-Owner: Varshit B Pandya
varshit.b.pandya@intel.com
Gerrit-Reviewer: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-Reviewer: Lance Zhao
Gerrit-Reviewer: Rizwan Qureshi
rizwan.qureshi@intel.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Poornima Tom
poornima.tom@intel.com
Gerrit-CC: Sumeet R Pawnikar
sumeet.r.pawnikar@intel.com
Gerrit-Attention: Lance Zhao
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Rizwan Qureshi
rizwan.qureshi@intel.com
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-Comment-Date: Sat, 02 Apr 2022 11:48:09 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-MessageType: comment