[coreboot-gerrit] [M] Change in coreboot[master]: soc/intel/meteoerlake: set power limits dynamically

[Subrata Banik (Code Review)]

Attention is currently required from: Tarun Tuli, Sumeet R Pawnikar, Eric Lai.

Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74380 )

Change subject: soc/intel/meteoerlake: set power limits dynamically
......................................................................

Patch Set 4:

(1 comment)

File src/soc/intel/meteorlake/chip.h:

https://review.coreboot.org/c/coreboot/+/74380/comment/a7adf267_f51c28e9 
PS2, Line 33: static const struct
> I would prefer to keep in this chip header file only because in future this list will grow with respect to different SKUs and TDPs. Please, refer alderlake/chip.h for an example.

Please refer to report_platform.c file. unless we need this data structure elsewhere its better to keep it as local as possible. https://github.com/coreboot/coreboot/blob/master/src/soc/intel/meteorlake/bo...