Attention is currently required from: Jason Glenesk, Marshall Dawson, Felix Held.
Raul Rangel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/61680 )
Change subject: soc/amd/common/block/pci/amd_pci_mmconf: add assert for MMCONF region
......................................................................
Patch Set 1:
(1 comment)
File src/soc/amd/common/block/pci/amd_pci_mmconf.c:
https://review.coreboot.org/c/coreboot/+/61680/comment/db13aa7e_e4355742
PS1, Line 15: CONFIG_ECAM_MMCONF_BASE_ADDRESS
Is it even possible for this #define to contain a 64 bit number? Doesn't the constant need the LL suffix to be considered a 64-bit number?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/61680
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib0b4443d7a86f20c4c2508a88db5d731560f8312
Gerrit-Change-Number: 61680
Gerrit-PatchSet: 1
Gerrit-Owner: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Attention: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Mon, 07 Feb 2022 17:31:30 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment