Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34344 )
Change subject: kukui: Introduce a new 'Jacuzzi' family
......................................................................
Patch Set 3:
(1 comment)
I'm a bit worried that the distinction between the kukui and jacuzzi baseboards may be too unclear.
https://review.coreboot.org/c/coreboot/+/34344/2//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/34344/2//COMMIT_MSG@7
PS2, Line 7: kukui: Introduce a new 'Jacuzzi' family.
Can you elaborate more on what does that mean - common prefix different for variants?
I don't understand what Paul means with the 2nd suggestion, but I'd change the "kukui:" at the beginning of the commit summary with "mb/kukui:".
--
To view, visit
https://review.coreboot.org/c/coreboot/+/34344
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic2b04e01628dc3db40f79f9bbdd5cc77d9466753
Gerrit-Change-Number: 34344
Gerrit-PatchSet: 3
Gerrit-Owner: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: You-Cheng Syu
youcheng@google.com
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Angel Pons
th3fanbus@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-CC: Zhuohao Lee
zhuohao@google.com
Gerrit-Comment-Date: Mon, 15 Jul 2019 16:04:54 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel
paulepanter@users.sourceforge.net
Comment-In-Reply-To: Hung-Te Lin
hungte@chromium.org
Gerrit-MessageType: comment