Edward O'Callaghan (eocallaghan@alterapraxis.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/4783
-gerrit
commit 82934226766008267682cf7159313e54ef2c8746 Author: Edward O'Callaghan eocallaghan@alterapraxis.com Date: Thu Jan 23 08:30:42 2014 +1100
[Trivial]: Fix two warnings while building libpayload.
Change-Id: Ia1fd545b39868a81cbc311f6ffc786f9f1f61415 Signed-off-by: Edward O'Callaghan eocallaghan@alterapraxis.com --- payloads/libpayload/drivers/storage/ahci.c | 3 +++ payloads/libpayload/libc/hexdump.c | 2 +- 2 files changed, 4 insertions(+), 1 deletion(-)
diff --git a/payloads/libpayload/drivers/storage/ahci.c b/payloads/libpayload/drivers/storage/ahci.c index ec4db4c..8a1aa98 100644 --- a/payloads/libpayload/drivers/storage/ahci.c +++ b/payloads/libpayload/drivers/storage/ahci.c @@ -328,6 +328,8 @@ static ssize_t ahci_ata_read_sectors(ata_dev_t *const ata_dev, return dev->cmdlist->prd_bytes >> ata_dev->sector_size_shift; }
+/* XXX: Currently defined but unused function */ +#if 0 static ssize_t ahci_packet_read_cmd(atapi_dev_t *const _dev, const u8 *const cmd, const size_t cmdlen, u8 *const buf, const size_t buflen) @@ -353,6 +355,7 @@ static ssize_t ahci_packet_read_cmd(atapi_dev_t *const _dev,
return ahci_cmdslot_exec(dev); } +#endif /* XXX */
static int ahci_identify_device(ata_dev_t *const ata_dev, u8 *const buf) { diff --git a/payloads/libpayload/libc/hexdump.c b/payloads/libpayload/libc/hexdump.c index e4aa8b9..44d1a45 100644 --- a/payloads/libpayload/libc/hexdump.c +++ b/payloads/libpayload/libc/hexdump.c @@ -49,7 +49,7 @@ void hexdump(void *memory, int length) }
if (all_zero < 2) { - printf("%08lx:", memory + i); + printf("%08lx:", (long unsigned int)memory + i); for (j = 0; j < 16; j++) printf(" %02x", m[i + j]); printf(" ");