Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48215 )
Change subject: cpu/x86/smm/smm_stub: Fix stack canary on x86_64
......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/48215/1/src/cpu/x86/smm/smm_stub.S
File src/cpu/x86/smm/smm_stub.S:
https://review.coreboot.org/c/coreboot/+/48215/1/src/cpu/x86/smm/smm_stub.S@...
PS1, Line 146: movl %ebx, (%ebx)
: #if ENV_X86_64
: movl $0, 4(%ebx)
: #endif
maybe movq $rbx, (%rbx) is clearer?
That can't be used as this code is still in protected mode.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/48215
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id805c65717ec22f413803c21928d070602522b2c
Gerrit-Change-Number: 48215
Gerrit-PatchSet: 1
Gerrit-Owner: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-CC: Patrick Rudolph
siro@das-labor.org
Gerrit-Comment-Date: Tue, 01 Dec 2020 16:26:16 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Arthur Heymans
arthur@aheymans.xyz
Gerrit-MessageType: comment