Attention is currently required from: Eric Lai, Kapil Porwal, Nick Vaccaro, Subrata Banik.
SH Kim has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80325?usp=email )
Change subject: mb/google/brya/var/xol: Update GPIO configurations
......................................................................
Patch Set 2:
(3 comments)
Patchset:
PS2:
Thanks for the remarks.
File src/mainboard/google/brya/variants/xol/Makefile.mk:
https://review.coreboot.org/c/coreboot/+/80325/comment/770e1b69_fbeab5d2 :
PS1, Line 4: romstage-y += gpio.c
remove too.
Done
File src/mainboard/google/brya/variants/xol/gpio.c:
https://review.coreboot.org/c/coreboot/+/80325/comment/e959d376_821e38a5 :
PS1, Line 211: const struct pad_config *variant_romstage_gpio_table(size_t *num)
you can remove if nothing to override.
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/80325?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I224e58628e44571c07ce034136d690587e62be08
Gerrit-Change-Number: 80325
Gerrit-PatchSet: 2
Gerrit-Owner: SH Kim
sh_.kim@samsung.corp-partner.google.com
Gerrit-Reviewer: Eric Lai
ericllai@google.com
Gerrit-Reviewer: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-CC: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Eric Lai
ericllai@google.com
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Kapil Porwal
kapilporwal@google.com
Gerrit-Attention: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Comment-Date: Fri, 02 Feb 2024 06:22:54 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Eric Lai
ericllai@google.com
Gerrit-MessageType: comment