Attention is currently required from: Jason Glenesk, Fred Reitberger.
Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68547 )
Change subject: soc/amd/morgana/i2c: Remove to-do after review
......................................................................
Patch Set 1: Code-Review+2
(1 comment)
File src/soc/amd/morgana/include/soc/i2c.h:
https://review.coreboot.org/c/coreboot/+/68547/comment/a2793346_16702010
PS1, Line 13: #define GPIO_I2C_MASK (GPIO_I2C0_SCL | GPIO_I2C1_SCL | \
: GPIO_I2C2_SCL | GPIO_I2C3_SCL)
:
would be great if you can do this improvement for the other amd socs too
--
To view, visit
https://review.coreboot.org/c/coreboot/+/68547
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I9d058b0f61b4784a1d83289e75705a6415405d0b
Gerrit-Change-Number: 68547
Gerrit-PatchSet: 1
Gerrit-Owner: Fred Reitberger
reitbergerfred@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Attention: Fred Reitberger
reitbergerfred@gmail.com
Gerrit-Comment-Date: Fri, 21 Oct 2022 14:48:36 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment