Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35864 )
Change subject: mb/lenovo/{t60,r60}: Add ThinkPad R60 support as variant board ......................................................................
Patch Set 63: Code-Review+1
(4 comments)
Not a fan of all the (dying) links.
https://review.coreboot.org/c/coreboot/+/35864/7//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/35864/7//COMMIT_MSG@12 PS7, Line 12: black on 1400x1050 IPS display[1]. Display works fine on Linux. I don't why it appears like that.
Yes it is
mention it in the commit message?
https://review.coreboot.org/c/coreboot/+/35864/63/Documentation/mainboard/le... File Documentation/mainboard/lenovo/r60.md:
https://review.coreboot.org/c/coreboot/+/35864/63/Documentation/mainboard/le... PS63, Line 16:  Should this refer to `r60_chip.jpg`?
https://review.coreboot.org/c/coreboot/+/35864/63/Documentation/mainboard/le... PS63, Line 18: To disassemble the laptop, follow the [Hardware Maintenance Manual](https://thinkpads.com/support/hmm/hmm_pdf/42x3749_02.pdf). In the long run, the full title would be more useful, IMHO. Links often turn out dead. A string to search the web for can't break.
https://review.coreboot.org/c/coreboot/+/35864/63/src/mainboard/lenovo/t60/K... File src/mainboard/lenovo/t60/Kconfig:
https://review.coreboot.org/c/coreboot/+/35864/63/src/mainboard/lenovo/t60/K... PS63, Line 35: t60 typo?