Attention is currently required from: Ashish Kumar Mishra.
Sowmya Aralguppe has posted comments on this change by Sowmya Aralguppe. ( https://review.coreboot.org/c/coreboot/+/84397?usp=email )
Change subject: mb/google/brox: Remove Platform(PSys) related implementation ......................................................................
Patch Set 3:
(2 comments)
File src/mainboard/google/brox/variants/baseboard/include/baseboard/variants.h:
https://review.coreboot.org/c/coreboot/+/84397/comment/b711da87_92301305?usp... : PS3, Line 58: struct psys_config {
Please update this struct reference in other brox variants, as well. Such as variants/jubilant. […]
psys_config and psys_pl2 power are not used in any Brox variant
https://review.coreboot.org/c/coreboot/+/84397/comment/f62acf10_e2b513df?usp... : PS3, Line 82: void variant_update_psys_power_limits(const struct cpu_power_limits *limits,
Please update this function call reference in other brox variants, as well. […]
https://review.coreboot.org/c/coreboot/+/84219 - this function is not called in Jubilant .The patch is already merged