Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36028 )
Change subject: google/chromeos: Add a library to get DSM calibration data
......................................................................
Patch Set 9: Code-Review+2
(1 comment)
https://review.coreboot.org/c/coreboot/+/36028/9/src/vendorcode/google/chrom...
File src/vendorcode/google/chromeos/dsm_calib.c:
https://review.coreboot.org/c/coreboot/+/36028/9/src/vendorcode/google/chrom...
PS9, Line 44: value_from_vpd < 0)
Is it expected that some calibration parameters could be 0? If they are resistor values and temperatures, I would not expect to find 0 in either of those values; would they just not be included in the VPD in that case?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/36028
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib9579a5cc055f8f438cb30a8acaf250a343db19e
Gerrit-Change-Number: 36028
Gerrit-PatchSet: 9
Gerrit-Owner: Cheng-Yi Chiang
cychiang@chromium.org
Gerrit-Reviewer: Cheng-Yi Chiang
cychiang@chromium.org
Gerrit-Reviewer: Duncan Laurie
dlaurie@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Jimmy Cheng-Yi Chiang
cychiang@google.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Paul Fagerburg
pfagerburg@chromium.org
Gerrit-Reviewer: Shelley Chen
shchen@google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Wed, 23 Oct 2019 15:34:29 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment