Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44023 )
Change subject: arch/x86/smbios.c: Split out weak functions
......................................................................
Patch Set 3:
Created a revert of this change as Ia09f25e64dfc46d230e7ec6faf335b1d04ee6f78
Sorry, I did not mean to provoke this. IMHO, a revert (after 2 months+)
has about the same traits as the original patch: I couldn't decide for
all affected developers if that makes it better.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/44023
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Idd2a4ba52b6b23aad8fd63e66ffa747d49ea713d
Gerrit-Change-Number: 44023
Gerrit-PatchSet: 3
Gerrit-Owner: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: 9elements QA
hardwaretestrobot@gmail.com
Gerrit-CC: Nico Huber
nico.h@gmx.de
Gerrit-Comment-Date: Fri, 13 Nov 2020 21:19:48 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment