Subrata Banik has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/74388 )
Change subject: soc/intel/cmn/cse: Make `cse_get_fpt_partition_info()` function static ......................................................................
soc/intel/cmn/cse: Make `cse_get_fpt_partition_info()` function static
The patch makes `cse_get_fpt_partition_info()` AP local/static as all the references to this function are in local to the cse_lite.c file.
BUGb:273661726 TEST=Able to build and boot google/marasov with this code change.
Signed-off-by: Subrata Banik subratabanik@google.com Change-Id: Ie50453946c8abe55c29e9001263f0264a73c8fac --- M src/soc/intel/common/block/cse/cse_lite.c M src/soc/intel/common/block/include/intelblocks/cse.h 2 files changed, 18 insertions(+), 8 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/88/74388/1
diff --git a/src/soc/intel/common/block/cse/cse_lite.c b/src/soc/intel/common/block/cse/cse_lite.c index 77b4559..e51f3e4 100644 --- a/src/soc/intel/common/block/cse/cse_lite.c +++ b/src/soc/intel/common/block/cse/cse_lite.c @@ -1228,7 +1228,8 @@ return CB_SUCCESS; }
-enum cb_err cse_get_fpt_partition_info(enum fpt_partition_id id, struct fw_version_resp *resp) +static enum cb_err cse_get_fpt_partition_info(enum fpt_partition_id id, + struct fw_version_resp *resp) { if (vboot_recovery_mode_enabled()) { printk(BIOS_WARNING, diff --git a/src/soc/intel/common/block/include/intelblocks/cse.h b/src/soc/intel/common/block/include/intelblocks/cse.h index be455c1..1b7e372 100644 --- a/src/soc/intel/common/block/include/intelblocks/cse.h +++ b/src/soc/intel/common/block/include/intelblocks/cse.h @@ -541,13 +541,6 @@ enum cb_err cse_get_fw_feature_state(uint32_t *feature_state);
/* - * The function sends a HECI command to get the partition information of the shared ID. - * The retrieved partition is stored in the memory pointed to by the resp pointer. - * The function returns 0 on success and < 0 on failure. - */ -enum cb_err cse_get_fpt_partition_info(enum fpt_partition_id id, struct fw_version_resp *resp); - -/* * This function updates the user-provided memory pointer 'resp_version' with the * current ISH version. User must allocate memory for resp_version. *