Attention is currently required from: Angel Pons, Arthur Heymans.
Nico Huber has posted comments on this change by Arthur Heymans. ( https://review.coreboot.org/c/coreboot/+/84007?usp=email )
Change subject: libpayload: Use unsigned integet for PDG_MASK
......................................................................
Patch Set 3: Code-Review+2
(1 comment)
File payloads/libpayload/arch/arm/virtual.c:
https://review.coreboot.org/c/coreboot/+/84007/comment/921f3371_4cd9547d?usp... :
PS3, Line 82: return 1 << PAGE_SHIFT;
Same "problem" here
I don't think it is. Shifting a signed but positive integer is defined.
The problem above, I guess, is that `~0` (to be read as `~(int)0`)
is negative.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/84007?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ic4ce64207393ec4a8d6b188b35e0f436342826de
Gerrit-Change-Number: 84007
Gerrit-PatchSet: 3
Gerrit-Owner: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Comment-Date: Fri, 23 Aug 2024 10:54:23 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com