build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/71708 )
Change subject: [WIP, POC]: Save postcode data to CBFS ......................................................................
Patch Set 1:
(3 comments)
File src/include/console/console.h:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-167764): https://review.coreboot.org/c/coreboot/+/71708/comment/e63621c0_1bef94e1 PS1, Line 24: #define POST_CODE_INIT_ATTR __attribute__((used, section(".post_code"))) Prefer __used over __attribute__((used))
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-167764): https://review.coreboot.org/c/coreboot/+/71708/comment/db68a757_8e96c1d4 PS1, Line 24: #define POST_CODE_INIT_ATTR __attribute__((used, section(".post_code"))) Prefer __section(".post_code") over __attribute__((section(".post_code")))
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-167764): https://review.coreboot.org/c/coreboot/+/71708/comment/058a004c_cafdd938 PS1, Line 35: static struct post_code_entry POST_CODE_INIT_ATTR POSTCODE_## VALUE = \ please, no space before tabs