Fred Reitberger has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/76165?usp=email )
Change subject: soc/amd/phoenix: Remove TODO after review ......................................................................
soc/amd/phoenix: Remove TODO after review
Signed-off-by: Fred Reitberger reitbergerfred@gmail.com Change-Id: Ifd2b53ff24776238190eb946db7b12827fcfc804 --- M src/soc/amd/phoenix/Kconfig M src/soc/amd/phoenix/include/soc/espi.h M src/soc/amd/phoenix/include/soc/uart.h 3 files changed, 1 insertion(+), 7 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/65/76165/1
diff --git a/src/soc/amd/phoenix/Kconfig b/src/soc/amd/phoenix/Kconfig index 4ab26ee..eb1ec56 100644 --- a/src/soc/amd/phoenix/Kconfig +++ b/src/soc/amd/phoenix/Kconfig @@ -42,7 +42,7 @@ select SOC_AMD_COMMON_BLOCK_ACPI_GPIO # TODO: Check if this is still correct select SOC_AMD_COMMON_BLOCK_ACPI_IVRS # TODO: Check if this is still correct select SOC_AMD_COMMON_BLOCK_AOAC - select SOC_AMD_COMMON_BLOCK_APOB # TODO: Check if this is still correct + select SOC_AMD_COMMON_BLOCK_APOB select SOC_AMD_COMMON_BLOCK_APOB_HASH select SOC_AMD_COMMON_BLOCK_BANKED_GPIOS select SOC_AMD_COMMON_BLOCK_CPUFREQ_FAM17H_19H diff --git a/src/soc/amd/phoenix/include/soc/espi.h b/src/soc/amd/phoenix/include/soc/espi.h index 057332a..5968da0e 100644 --- a/src/soc/amd/phoenix/include/soc/espi.h +++ b/src/soc/amd/phoenix/include/soc/espi.h @@ -1,7 +1,5 @@ /* SPDX-License-Identifier: GPL-2.0-only */
-/* TODO: Update for Phoenix */ - #ifndef AMD_PHOENIX_ESPI_H #define AMD_PHOENIX_ESPI_H
diff --git a/src/soc/amd/phoenix/include/soc/uart.h b/src/soc/amd/phoenix/include/soc/uart.h index b8d6e17..5b941b2 100644 --- a/src/soc/amd/phoenix/include/soc/uart.h +++ b/src/soc/amd/phoenix/include/soc/uart.h @@ -1,12 +1,8 @@ /* SPDX-License-Identifier: GPL-2.0-only */
-/* TODO: Update for Phoenix */ - #ifndef AMD_PHOENIX_UART_H #define AMD_PHOENIX_UART_H
-#include <types.h> - void clear_uart_legacy_config(void); /* disable legacy I/O decode for FCH UART */
#endif /* AMD_PHOENIX_UART_H */