Werner Zeh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35594 )
Change subject: mb/siemens/mc_bdx1: Enable VBOOT ......................................................................
Patch Set 2:
(2 comments)
https://review.coreboot.org/c/coreboot/+/35594/1/src/mainboard/siemens/mc_bd... File src/mainboard/siemens/mc_bdx1/Kconfig:
https://review.coreboot.org/c/coreboot/+/35594/1/src/mainboard/siemens/mc_bd... PS1, Line 18: select BOOT_DEVICE_SPI_FLASH_RW_NOMMAP_EARLY : select BOOT_DEVICE_SUPPORTS_WRITES
I don't see it on SoC level for now but I might miss something. […]
Do you insist on moving these switches to SoC? I mean I can do it if you see it as absolutely necessary.
https://review.coreboot.org/c/coreboot/+/35594/1/src/mainboard/siemens/mc_bd... PS1, Line 32: default "src/mainboard/$(CONFIG_MAINBOARD_DIR)/mc_bdx1.fmd"
Sounds nice, will try.
Ack